MapInfo Pro Developers User Group

Hello all,

I am reading the documents "How to customize the mapinfo pro ribbon interface" and "Porting simple applications to the ribbon interface using mapbasic"

My code (below) does not work. It creates a tab, a tab group and a button, but when I click on the button, nothing happens.

'Ribbon

Include "mapbasic.def"

Include "IMapInfoPro.def"

Include "Enums.def"

Declare Sub Main

Declare Sub Button1Sub

Sub Main

Dim mapinfoApplication As This

Dim Ribbon As This

Dim RibbonTabColl As This

Dim RibbonTab As This

Dim ribbonGroupsColl As This

Dim ribbonGroup As This

Dim groupControlColl As This

Dim button1 As This

mapinfoApplication = SystemInfo(SYS_INFO_IMAPINFOAPPLICATION)

Ribbon = GetRibbon(mapinfoApplication)

RibbonTabColl = GetTabsColl(Ribbon)

RibbonTab = RbnTabCollAddStrStr(RibbonTabColl,"TabID","Tab Name")

ribbonGroupsColl = GetRbnTabGrps(RibbonTab)

ribbonGroup = RbnCtrlGrpCollAddStrStr(ribbonGroupsColl,"GroupID","Group Name")

groupControlColl = GetRbnCtrlGrpCtrls(ribbonGroup)

button1 = MICtrlCollAddStrStrInt(groupControlColl,"Button1ID","Button Name",ControlType_Button)

Call SetRbnBtnCtrlIsLarge(button1,TRUE)

Call SetRbnBtnCtrlCallingHandler(button1,"Button1Sub")

End Sub

Sub Button1Sub

Note "Pressed button1"

End Sub

After some more fiddling about, I got it to work with this code (below)

Pressing the first button works

Pressing the second button closes the app

'Ribbon

Include "mapbasic.def"

Include "IMapInfoPro.def"

Include "Enums.def"

Dim mapinfoApplication As This

Dim Ribbon As This

Dim RibbonTabColl As This

Dim RibbonTab As This

Dim ribbonGroupsColl As This

Dim ribbonGroup As This

Dim groupControlColl As This

Dim button1 As This

Dim button2 As This

Declare Sub Main

Declare Sub Button1Sub

Declare Sub EndHandler

Declare Sub GoodBye

Sub Main

mapinfoApplication = SystemInfo(SYS_INFO_IMAPINFOAPPLICATION)

Ribbon = GetRibbon(mapinfoApplication)

RibbonTabColl = GetTabsColl(Ribbon)

RibbonTab = RbnTabCollAddStrStr(RibbonTabColl,"TabID","Tab Name")

ribbonGroupsColl = GetRbnTabGrps(RibbonTab)

ribbonGroup = RbnCtrlGrpCollAddStrStr(ribbonGroupsColl,"GroupID","Group Name")

groupControlColl = GetRbnCtrlGrpCtrls(ribbonGroup)

button1 = MICtrlCollAddStrStrInt(groupControlColl,"Button1ID","Button Name",ControlType_Button)

Call SetRbnBtnCtrlIsLarge(button1,TRUE)

Call SetRbnBtnCtrlCallingHandler(button1,"Button1Sub")

button2 = MICtrlCollAddStrStrInt(groupControlColl,"Button1ID","Good Bye",ControlType_Button)

Call SetRbnBtnCtrlIsLarge(button2,TRUE)

Call SetRbnBtnCtrlCallingHandler(button2,"GoodBye")

End Sub

Sub Button1Sub

Note "Pressed button1"

End Sub

Sub GoodBye

Print "GoodBye"

End Program

End Sub

Sub EndHandler

Dim bRemoved As Logical

Print "EndHandler activated"

bRemoved = MICtrlCollRemove(groupControlColl,button1)

button1 = NULL_PTR

bRemoved = MICtrlCollRemove(groupControlColl,button2)

button2 = NULL_PTR

bRemoved = RbnTabCollRemove(RibbonTabColl,RibbonTab)

RibbonTab = NULL_PTR

End Sub

One of the typical pitfalls that I have fallen into a number of times, is not having the Endhandler that that clean up the controls added when the applications ends.

This is required when you compile your source code when a MapBasic compiler for 64 bit.

If it isn't there, the application loads, add the controls and end again without removing the controls. This leads you into all sorts of funny experiments until you realise that the tool isn't even running and that's the reason why nothing happen when you click on the controls.

Could that have been the reason why your first example didn't work?

Yes, the main difference between my two drafts of code is that I added an EndHandler routine.

Thanks Peter!

Hi Nick, Peter,

Thanks for this, while I have not contributed to this issue, I now have a much clearer idea of how to port my own map basic applications to the Ribbon Bar?.

This is exactly the type of thing I needed, thank you very much to you both.

cheers

Peter

I found the only way to get the button to function properly was to call the sub a second time using;

Alter Menu ID 4 Add

"&Record Selector..." Calling recSelector

The code below did not work on its own.

call SetRbnBtnCtrlCallingHandler(recselBtn, "recSelector")

No idea why this should be so.

Toby, do you have an EndHandler in your application? If not, this might be the cause.

Yes, its working fine. I just thought it was odd, that without the End Handler or 'Alter Menu ID 4' code the button wouldn't function even though it has a calling handler.